Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update GENC scraper #345

Merged
merged 1 commit into from
Oct 1, 2024
Merged

update GENC scraper #345

merged 1 commit into from
Oct 1, 2024

Conversation

cjyetman
Copy link
Collaborator

@cjyetman cjyetman commented Sep 9, 2023

CAUTION: this does cause 2 deletions and numerous additions to the CSV data

@cjyetman cjyetman marked this pull request as draft September 9, 2023 11:24
@cjyetman
Copy link
Collaborator Author

@vincentarelbundock this removes "WESTERN SAHARA" and "BONAIRE, SINT EUSTATIUS, AND SABA", which I believe is correct (i.e. they don't appear to be included in GENC, Edition 3.0, Update 17 as of 30 June 2022).

But it also adds a bunch of territories... would you prefer to use a not_countries type list to filter them out, or is it ok to leave them in the archived GENC data because they won't get merged into the codelist when you run build.R anyway?

@cjyetman cjyetman marked this pull request as ready for review September 27, 2024 17:14
@vincentarelbundock
Copy link
Owner

Probably fine to leave them in, no?

@cjyetman
Copy link
Collaborator Author

I think so, but I don't ever use the build.R script, so not 100% sure of the expectations there.

@vincentarelbundock vincentarelbundock merged commit b4d17e6 into main Oct 1, 2024
6 checks passed
@cjyetman cjyetman deleted the update-genc-scraper branch October 1, 2024 13:09
@vincentarelbundock
Copy link
Owner

@cjyetman I had to make minor adjustements to get_genc.R because calling CountryToRegex(genc$country) in the build script generated some missing values and duplicates. Not a big deal at all. Just an FYI.

Dictionary should be updated now on Github.

Do we need a release?

@cjyetman
Copy link
Collaborator Author

cjyetman commented Oct 1, 2024

Do we need a release?

The past few merges are mostly inconsequential if at all, from a user perspective. #347 is a more important fix that would more reasonably warrant a release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants